Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workflows): updates for custom github org #102

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

noelmcloughlin
Copy link
Contributor

This PR is some updates to github workflows which should be non-breaking.

I'm running workflow steps inside a container and needed some adjustments.

Also gh-pages branch is not configured in my github organization so documenting alternative steps.

@noelmcloughlin noelmcloughlin changed the title refactor(workflows): improved workflows refactor(workflows): update workflows for custom github org Feb 28, 2024
@noelmcloughlin noelmcloughlin changed the title refactor(workflows): update workflows for custom github org refactor(workflows): updates for custom github org Feb 28, 2024
@turbomam
Copy link

Thanks @noelmcloughlin

What's the motivation for using

python3 -m pip install --user pipx and python3 -m pipx instead of poetry (or pipx directly)?

I have pipx and poetry installed as system dependencies, so I always thought of them as soft requirements for doing LinkML development.

@dalito
Copy link
Contributor

dalito commented Feb 28, 2024

The reason is that pipx is not in his container in contrast to the github action containers which have it by default. Maybe the changes to run without pages and without pipx can be put into a customization md file instead? Then the action file could stay short.

@noelmcloughlin
Copy link
Contributor Author

Hi,
My environment is heavily regulated. GitHub Runners only have system python-3.6 so I need to use a container which has multiple python in /bin directory. The following throws error for me:

      - name: Set up Python.
        uses: actions/setup-python@v4
        with:
          python-version: 3.9

So in my PR I explicitly call python3 -m pip just to be explicit. And in real life I actually invoke python3.11 -m pip since that is what I'm using inside container.

Let me do some further thinking on this - maybe my PR needs more work.

@noelmcloughlin noelmcloughlin marked this pull request as draft February 28, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants